This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
Allow graphql 0.13 as peer dep #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM ? |
|
Hi what do we have to do to get this released? Anything I can do to help? |
|
Especially since the last version bump to 0.12 has not yet been published to npm, it would be really great if this could be merged and published anytime soon. This not only causes warnings but makes it really hard (or impossible) to find a supported graphql version in a simplified NPM environment like StackBlitz where peer dependencies are automatically resolved. |
|
@asiandrummer 🏓 🙂 |
|
Had to remove graphiql from my build because of this not being merged yet :( |
|
Can we have it merged please? |
|
Hey everyone, sorry for the delay with this. @danez thanks for taking the time to do this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates graphql + codemirror for the tests.