Remove stats.New
#2442
Merged
Remove stats.New
#2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
force-pushed
the
refactor/remove_stats_New
branch
from
d701440
to
c029ecb
Compare
oleiade
force-pushed
the
refactor/remove_stats_New
branch
from
c029ecb
to
6d90d23
Compare
oleiade
force-pushed
the
refactor/remove_stats_New
branch
4 times, most recently
from
3b9c4c4
to
a69cc06
Compare
oleiade
force-pushed
the
refactor/remove_stats_New
branch
4 times, most recently
from
750b46d
to
83d73fc
Compare
|
Rebased this on #2426. This now depends on said PR. A notable change made is that we now use the The failing tests are inherited from #2426 and the PR should be green once those issues are addressed in said PR. |
olegbespalov
previously approved these changes
Mar 18, 2022
na--
force-pushed
the
cleanup-7
branch
2 times, most recently
from
591a0fe
to
f06d6f0
Compare
oleiade
force-pushed
the
refactor/remove_stats_New
branch
from
83d73fc
to
393d188
Compare
oleiade
force-pushed
the
refactor/remove_stats_New
branch
from
393d188
to
f168a73
Compare
na--
force-pushed
the
cleanup-7
branch
3 times, most recently
from
58fca82
to
8276246
Compare
oleiade
force-pushed
the
refactor/remove_stats_New
branch
from
f168a73
to
2673d98
Compare
This commit drops the dependency on `stats.New`, in favor of `metrics.Registry.NewMetric`, which is considered the canonical way of creating metrics.
na--
reviewed
Mar 29, 2022
| if len(t) > 0 { | ||
| vt = t[0] | ||
| // newMetric instantiates a new Metric | ||
| func newMetric(name string, mt MetricType, vt ...ValueType) *Metric { |
There was a problem hiding this comment.
I am guessing this will get deleted when things are moved to metrics/?
There was a problem hiding this comment.
I ended up keeping it around, but private to, and only used in, the metrics package; as a helper. See #2442 (comment) for more details :)
oleiade
force-pushed
the
refactor/remove_stats_New
branch
from
2673d98
to
f75251f
Compare
na--
approved these changes
Mar 29, 2022
olegbespalov
approved these changes
Mar 29, 2022
imiric
pushed a commit
to grafana/xk6-browser
that referenced
this pull request
May 5, 2022
This is a fix for a breaking change introduced in k6 v0.38.0[1]. [1]: grafana/k6#2442
This was referenced Jun 9, 2022
This was referenced Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
stats.Newmethod from thestatspackage. This change is intended to facilitate the move of thestatspackage code in a top-levelmetricscode. It was triggered and requested, as preparation step to #2433 and #2426.Note that this PR might be taking certain shortcut, assuming the API will be readjusted later by the mentioned PRs.
Question marks
I took the initiative to use the
registry.NewMetricin places wherestats.Newused to be. I could see two main alternatives:registry.MustNewMetric, but considering we userequire.NoErroreverywhere else, I pickedregistry.NewMetricinsteadMetricinstances “manually” everywhere it's possible. However, considering we want to explicit that metrics should be created through a registry, I judged it more relevant.Dependencies
This should be merged before #2433 and #2426