Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic on no arguments to metric.Add() #2427

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Don't panic on no arguments to metric.Add() #2427

merged 2 commits into from
Mar 9, 2022

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Mar 9, 2022

No description provided.

@mstoykov mstoykov added this to the v0.37.0 milestone Mar 9, 2022
olegbespalov
olegbespalov previously approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mstoykov mstoykov merged commit 55c7ccd into master Mar 9, 2022
@mstoykov mstoykov deleted the fixPanicInMetricAdd branch March 9, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@olegbespalov olegbespalov olegbespalov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.37.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @codebien @olegbespalov