Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon to Grizzly Server #473

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Add favicon to Grizzly Server #473

merged 2 commits into from
Aug 14, 2024

Conversation

malcolmholmes
Copy link
Contributor

Shows up in browser tab, which will help to identify the tab when there are many.

w.Header().Set("Content-Type", "image/x-icon")
w.WriteHeader(http.StatusOK)
w.Write(content)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these lint errors resolvable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, on it.

@malcolmholmes malcolmholmes merged commit 8b8f31f into main Aug 14, 2024
7 checks passed
@malcolmholmes malcolmholmes deleted the malcolmholmes/favicon branch August 14, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants