Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix and major refactor of code #21

Merged
merged 21 commits into from
Jun 1, 2017
Merged

bug fix and major refactor of code #21

merged 21 commits into from
Jun 1, 2017

Conversation

drossetti
Copy link
Contributor

fixes #11 #9 #4 #5 #20

drossetti and others added 21 commits May 26, 2017 17:56
@drossetti
assorted clean-ups
e32ee27 
fixes #11
note: it breaks ABI, need to bump major version
@drossetti
add flags param to gds_stream_post_descriptors
12178fd
@drossetti
consolidate APIs into apis.cpp
d7609f5
@drossetti
use descriptor APIs
6df673c
@drossetti
remove useless code
9b9df07
@Akshay-Venkatesh @drossetti
right type for write descriptor
54e0b97
@drossetti
move desc as 1st param in gds_prepare_wait|write_value32()
9bb7447
@drossetti
fix bug: make sanity checkers conform to C++ conventions
9b00f7b
@drossetti
use descriptor APIs for write32 and wait32
567e37a
@drossetti
add descriptor APIs support (-U) to gds kernel latency tests
626882e
@e-ago @drossetti
send updated + rollback function (old changes applied to new branch)
40f993b
@drossetti
change extended param name for -U, add support for USE_GPU
32c504c
@e-ago @drossetti
Warnings fixed
1a92e95
@drossetti
use exp_ verbs names instead of a custom abstracted names
b030bc7
@drossetti
minor clean-ups in test/
aaf966f
@drossetti
get rid of gds_register_peer()
0cdf58d
@drossetti
move APIs into separate sections and add initial documentation
951813f
@drossetti
fix build problem with device.cuh
ac773e3 
todo: need a unit test for this
@drossetti
protect from inclusion in C modules. fix build error.
3ca6da9
@drossetti
include device.cuh as sanity check
e512e98
@drossetti
propagate CPPFLAGS to CUDA C builds
a7e902a
@drossetti drossetti requested a review from e-ago May 27, 2017 01:14
@drossetti
Copy link
Contributor Author

@e-ago could you please review this pull ?

e-ago
e-ago approved these changes Jun 1, 2017
View reviewed changes
Copy link
Collaborator

@e-ago e-ago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and there is no issue compiling the new libmp ofed4.0 over this branch

@drossetti drossetti merged commit 513efc1 into devel Jun 1, 2017
@drossetti drossetti deleted the cleaups branch June 1, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-ago e-ago e-ago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drossetti @e-ago @Akshay-Venkatesh