Debugger: resolve source location #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chingor13
changed the title
chingor13
changed the title
tmatsuo
reviewed
Jan 18, 2018
| public function __construct($searchPath, $file) | ||
| { | ||
| parent::__construct( | ||
| new \RecursiveIteratorIterator( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tmatsuo
reviewed
Jan 18, 2018
| public function accept() | ||
| { | ||
| $candidate = $this->getInnerIterator()->current(); | ||
| return strrpos($candidate, $this->file) === strlen($candidate) - strlen($this->file); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| { | ||
| public function testFindsMany() | ||
| { | ||
| // There are many files that end in Connection/RestTest.php in the test/unit folder |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tmatsuo
approved these changes
Jan 18, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requested source location may not exist with the exact path (although for most cases it will be).
Adding a SourceLocationResolver class that searches for the requested source location in the source tree. This resolution hits the file system, but is run from the separate daemon process and should not affect each individual request. When the daemon fetches the list of breakpoints, it validates them (including resolving the location) before saving them to the breakpoint storage. The agent that reads from the breakpoint storage can trust that the source location has been normalized (found).