Skip to content

Commit

Permalink
chore!: create V2 release candidates for some components (#7577)
Browse files Browse the repository at this point in the history
* chore!: promote ResourceSettings to v2
* chore!: promote ManagedIdentities to v2
* chore!: promote NetworkConnectivity to v2
* chore!: promote ApigeeConnect to v2
* chore!: promote Dms to v2
* chore!: promote OrchestrationAirflow to v2
* chore!: promote NetworkManagement to v2
* chore!: promote DataCatalog to v2
* chore!: promote ContactCenterInsights to v2
* chore!: promote BigQueryReservation to v2
* chore!: promote BillingBudgets to v2
* chore!: promote OsLogin to v2
* chore!: promote Filestore to v2
* chore!: promote Eventarc to v2
* chore!: promote AccessApproval to v2
* chore!: promote PolicyTroubleshooter to v2
* chore!: promote Recommender to v2
* chore!: promote Shell to v2
  • Loading branch information
bshaffer authored Aug 2, 2024
1 parent c5b4542 commit aca00f6
Show file tree
Hide file tree
Showing 1,047 changed files with 7,522 additions and 84,626 deletions.
4 changes: 2 additions & 2 deletions AccessApproval/.OwlBot.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
deep-copy-regex:
- source: /google/cloud/accessapproval/v1/.*-php/(.*)
dest: /owl-bot-staging/AccessApproval/v1/$1
- source: /google/cloud/accessapproval/(v1)/.*-php/(.*)
dest: /owl-bot-staging/AccessApproval/$1/$2
api-name: AccessApproval
51 changes: 16 additions & 35 deletions AccessApproval/owlbot.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2021 Google LLC
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -14,9 +14,9 @@

"""This script is used to synthesize generated parts of this library."""


import logging
from pathlib import Path
import subprocess

import synthtool as s
from synthtool.languages import php
Expand All @@ -30,14 +30,7 @@
# Added so that we can pass copy_excludes in the owlbot_main() call
_tracked_paths.add(src)

php.owlbot_main(
src=src,
dest=dest,
copy_excludes=[
src / "**/[A-Z]*_*.php",
src / "**/*GrpcClient.php",
]
)
php.owlbot_main(src=src, dest=dest)

# remove class_alias code
s.replace(
Expand All @@ -48,28 +41,16 @@
+ "\n",
'')

# [START] protoc backwards compatibility fixes

# roll back to private properties.
s.replace(
"src/**/V*/**/*.php",
r"Generated from protobuf field ([^\n]{0,})\n\s{5}\*/\n\s{4}protected \$",
r"""Generated from protobuf field \1
*/
private $""")

# Replace "Unwrapped" with "Value" for method names.
s.replace(
"src/**/V*/**/*.php",
r"public function ([s|g]\w{3,})Unwrapped",
r"public function \1Value"
)

# [END] protoc backwards compatibility fixes

# fix relative cloud.google.com links
s.replace(
"src/**/V*/**/*.php",
r"(.{0,})\]\((/.{0,})\)",
r"\1](https://cloud.google.com\2)"
)
# format generated clients
subprocess.run([
'npm',
'exec',
'--yes',
'--package=@prettier/plugin-php@^0.16',
'--',
'prettier',
'**/Client/*',
'--write',
'--parser=php',
'--single-quote',
'--print-width=120'])
34 changes: 0 additions & 34 deletions AccessApproval/src/V1/AccessApprovalClient.php

This file was deleted.

4 changes: 2 additions & 2 deletions AccessApproval/src/V1/AccessApprovalServiceAccount.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions AccessApproval/src/V1/AccessApprovalSettings.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions AccessApproval/src/V1/AccessLocations.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions AccessApproval/src/V1/AccessReason.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions AccessApproval/src/V1/ApprovalRequest.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions AccessApproval/src/V1/ApproveApprovalRequestMessage.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions AccessApproval/src/V1/ApproveDecision.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit aca00f6

Please sign in to comment.