Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [apihub] new module for apihub #11089

Merged
merged 2 commits into from
Aug 21, 2024
Merged

feat: [apihub] new module for apihub #11089

merged 2 commits into from
Aug 21, 2024

Conversation

cloud-java-bot
Copy link
Collaborator

@cloud-java-bot cloud-java-bot commented Aug 21, 2024 •
edited by mpeddada1
Loading

Generated by @mpeddada1 via generate_new_client_hermetic_build.yaml

Command used:

python generation/new_client_hermetic_build/add-new-client-config.py add-new-client --api-shortname "apihub" --name-pretty "API hub API" --api-description "API hub lets you consolidate and organize information about all of the APIs     of interest to your organization. API hub lets you capture critical information about APIs that allows developers to discover and evaluate     them easily and leverage the work of other teams wherever possible. API     platform teams can use API hub to have visibility into and manage their portfolio of APIs." --proto-path "google/cloud/apihub/v1" --product-docs "https://cloud.google.com/apigee/docs/apihub/what-is-api-hub"

PiperOrigin-RevId: 658810011

@cloud-java-bot cloud-java-bot requested a review from a team as a code owner August 21, 2024 13:47
@cloud-java-bot cloud-java-bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 21, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Aug 21, 2024

Here is the summary of changes.

You are about to add 304 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@ldetmer
Copy link
Contributor

ldetmer commented Aug 21, 2024

does it matter that the unmanaged dependency check is failing, is this okay because we're adding a new library with new dependencies?

This pull request seems to add new third-party dependency, [com.google.cloud.opentelemetry:exporter-metrics, com.google.cloud.opentelemetry:shared-resourcemapping], among the artifacts listed in gapic-libraries-bom/pom.xml.

@mpeddada1
Copy link
Contributor

does it matter that the unmanaged dependency check is failing, is this okay because we're adding a new library with new dependencies?

This pull request seems to add new third-party dependency, [com.google.cloud.opentelemetry:exporter-metrics, com.google.cloud.opentelemetry:shared-resourcemapping], among the artifacts listed in gapic-libraries-bom/pom.xml.

Thanks for the question! This check is currently failing for all PRs in the google-cloud-java repo and isn't unique to the changes in the PR. It should be resolved once googleapis/sdk-platform-java#3078 is merged and released in the next cycle. cc/ @JoeWang1127

@JoeWang1127
Copy link
Contributor

This check is currently failing for all PRs

This is because java-notification imports google-cloud-storage (source) and java-notification is part of gapic-libraries-bom.

Yes, the check should be fine when googleapis/sdk-platform-java#3078 is merged.

@mpeddada1 mpeddada1 merged commit 4b97769 into main Aug 21, 2024
30 of 31 checks passed
@mpeddada1 mpeddada1 deleted the new-library/apihub-2lngf branch August 21, 2024 17:22
@release-please release-please bot mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldetmer ldetmer ldetmer approved these changes

@burkedavison burkedavison Awaiting requested review from burkedavison

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cloud-java-bot @ldetmer @mpeddada1 @JoeWang1127 @yoshi-kokoro