chore: Disable OwlBot PRs. #10696
Merged
chore: Disable OwlBot PRs. #10696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you use an command to rename the files? Could you add the command in the description? |
JoeWang1127
approved these changes
Apr 15, 2024
Yes, this is the command I used |
diegomarquezp
approved these changes
Apr 15, 2024
This was referenced Apr 15, 2024
blakeli0
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Apr 16, 2024
…ml. (#2642) This is follow up of googleapis/google-cloud-java#10696. The hermetic build generation process would fail without this PR due to unable to find OwlBot.yaml files. This PR changes all the references of `OwlBot.yaml` to `OwlBot-hermetic.yaml`, removes `OwlBot.yaml` from a few places that don't need to reference it in the first places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Now that we set up daily hermetic build generation which would creates one PR for googleapis proto changes for all services, and it has been working consistently for the last ~4 weeks, we can safely disable OwlBot PRs.
How
OwlBot is installed org wide and we can not disable it for a single repo. The bot uses the existence of
.OwlBot.yamlto determine if a PR needs to be created. Hence, in order to disable OwlBot PRs, all.OwlBot.yamlfiles are renamed to.Owlbot-hermetic.yaml, all references to.OwlBot.yamlare also updated.Next
Once this PR is merged, the hermetic build generation will start to fail due to the assumption in hermetic build scripts that each library must contains a
.OwlBot.yamlfile. A follow up PR will be created insdk-platform-javato address it.