Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(main): release 1.35.0 #10660

Merged
merged 14 commits into from
Apr 4, 2024
Merged

chore(main): release 1.35.0 #10660

merged 14 commits into from
Apr 4, 2024

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Apr 4, 2024 •
edited
Loading

🤖 I have created a release beep boop

1.35.0

1.35.0 (2024-04-04)

Features

  • [speech] add translation_config in RecognitionConfig message (2e05371)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested review from a team as code owners April 4, 2024 17:56
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2024
@mpeddada1
Copy link
Contributor

Verification:

  • One non-speech related change was merged since last release but it was a README update.
Screenshot 2024-04-04 at 1 57 50 PM

@release-please release-please bot force-pushed the release-please--branches--main branch from 8e3688b to 8644483 Compare April 4, 2024 18:02
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 4, 2024
@suztomo
Copy link
Member

suztomo commented Apr 4, 2024

Strange. There are SNAPSHOT versions in pom.xml files, again.

[email protected] ~/google-cloud-java
~/google-cloud-java $ find . -name pom.xml |xargs grep SNAPSHOT                                                        
./java-video-intelligence/pom.xml:        <version>2.4.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-video-intelligence-bom:current} -->
./java-talent/pom.xml:        <version>2.6.1-SNAPSHOT</version> <!-- {x-version-update:google-cloud-talent-bom:current} -->

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2024
suztomo
suztomo requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking SNAPSHOT versions

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2024
@mpeddada1
Copy link
Contributor

Hmm good catch. Marking this as do-not-merge until this is addressed.

@mpeddada1 mpeddada1 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 4, 2024
@mpeddada1
Copy link
Contributor

GA builds seem to be stuck, closing and re-opening PR.

@mpeddada1 mpeddada1 closed this Apr 4, 2024
@mpeddada1 mpeddada1 reopened this Apr 4, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2024
@mpeddada1 mpeddada1 merged commit 517768d into main Apr 4, 2024
30 checks passed
@mpeddada1 mpeddada1 deleted the release-please--branches--main branch April 4, 2024 20:17
@release-please Release Please
Copy link
Contributor Author

release-please bot commented Apr 4, 2024

🤖 Release is at https://github.com/googleapis/google-cloud-java/releases/tag/v1.35.0 🌻

@release-trigger Release Trigger
Copy link

Triggered job: cloud-devrel/client-libraries/java/google-cloud-java/release/stage (2024-04-04T20:17:58.293Z)

To trigger again, remove the autorelease: triggered label (in a few minutes).

@release-tool-publish-reporter Release Tool Publish Reporter
Copy link

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter Release Tool Publish Reporter
Copy link

🥚 You hatched a release! The release build finished successfully! 💜

@release-tool-publish-reporter Release Tool Publish Reporter
Copy link

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter Release Tool Publish Reporter
Copy link

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Assignees
No one assigned
Labels
autorelease: published
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpeddada1 @suztomo @yoshi-kokoro @yoshi-code-bot