Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto-lens-descriptors version bound for lens-labels is too permissive #122

Closed
shlevy opened this issue Aug 15, 2017 · 0 comments
Closed

Comments

@shlevy
Copy link
Contributor

shlevy commented Aug 15, 2017

Build fails due to lack of HasLens' class when building against latest release of lens-labels instead of from git

judah added a commit to judah/proto-lens that referenced this issue Sep 25, 2017
Also updates a couple missing entries in the changelog.

Fixes google#122.
blackgnezdo pushed a commit that referenced this issue Sep 27, 2017
Also updates a couple missing entries in the changelog.

Fixes #122.
blackgnezdo pushed a commit that referenced this issue Aug 17, 2018
Also bump the version to 0.1.0.2.

Originally we had `extra-lib-dirs: /usr/local/lib` in `stack.yaml`.
I removed it because it wasn't necessary on my Mac.  However,
it turns out that it is necessary for machines with the default installation
of XCode, which *doesn't* search that path by default.

(On my machine, it wasn't necessary because I had run `xcode-select --install`
which adds that path permanently to your search path.  For more context, see
Homebrew/brew#556.)

I'm adding the setting back to `tensorflow.cabal` as well as `stack.yaml` so
that the Hackage release also contains this fix.  Changing `stack.yaml` is
still necessary in order to fix linkage in the `snappy` package (which
`tensorflow-records` depends on).  Hopefully that will go away once we remove
the dependency (#118).
avdv pushed a commit to avdv/proto-lens that referenced this issue Aug 9, 2023
Also updates a couple missing entries in the changelog.

Fixes google#122.
ylecornec pushed a commit to ylecornec/proto-lens that referenced this issue Feb 19, 2024
Also updates a couple missing entries in the changelog.

Fixes google#122.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant