Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all_the_things.py PASS by default, console_summary.py handle UNSET #851

Merged
merged 3 commits into from
Jan 14, 2019
Merged

all_the_things.py PASS by default, console_summary.py handle UNSET #851

merged 3 commits into from
Jan 14, 2019

Conversation

kdsudac
Copy link
Collaborator

@kdsudac kdsudac commented Jan 14, 2019 •
edited
Loading

Make all_the_things.py PASS by default.

Make console_summary do a better job of handling UNSET dimensions (previously did not print out this as reason for test failure).

This change is Reviewable

@kdsudac
Copy link
Collaborator Author

kdsudac commented Jan 14, 2019

This addresses: #734

@kdsudac kdsudac merged commit 6ab5c09 into google:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsharma1 arsharma1 arsharma1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdsudac @arsharma1