Add measurement-affecting .with_args to an example #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdsudac
approved these changes
Jun 7, 2017
| """This tests that we can ping a host. | ||
|
|
||
| The plug, pinger, is expected to be replaced at test creation time, so the | ||
| placeholder property was used instead of the class directly. | ||
| """ | ||
| del expected_retcode # Not used in the phase, only used by a measurement |
There was a problem hiding this comment.
I'd probably leave this line out because I think it is likely to confuse people new to htf.
You are really deleting only for linter, not really because it's a good practice.
There was a problem hiding this comment.
I'm making it clear that it has to be an input argument but doesn't have to be used in the phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.