Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check return value of TableBuilder::Add() in compaction routine. #1179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check return value of TableBuilder::Add() in compaction routine. #1179

wants to merge 1 commit into from

Commits on Apr 9, 2024

  1. Check return value of TableBuilder::Add() in compaction routine. 

    This is a prospective fix for the crash described in
crbug.com/326566884. Inspection of the crash dump suggests that
`Add()` is failing, but the compaction routine is continuing to
run. While it's not entirely clear how precisely this leads to
the observed failure mode, it seems safer to check the status
of the TableBuilder and abort early as needed.
    Evan Stade committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    80d6c09 View commit details
    Browse the repository at this point in the history