handle internal names and JvmName annotations for name mangling. #1901
Conversation
| ?.ktClassOrObjectSymbol?.psi as? KtClassOrObject | ||
| )?.toLightClass()?.allMethods?.filterIsInstance<SymbolLightSimpleMethod>() | ||
| ?.singleOrNull { | ||
| (it.parameters.isNotEmpty() xor (accessor is KSPropertyGetter)) && |
There was a problem hiding this comment.
This line is very tricky, the idea is we don't have a way to tell if a light method is getter or setter, and both getter and setter shares a same property declaration as the kotlinOrigin, so we just check if an accessor has any parameters to determine whether it is a getter or setter.
Will this ever be available in standalone mode? Does it require indexing of binary dependencies? |
That's something we need to investigate further. Currently there are already library symbols with a stub in KSP2, see #1873 |
putting it in draft mode since this PR only fixes source symbols. Theoretically it should handle library symbols if psi stub creation for library symbols are in place (as per the document of the psi elements in analysis API symbols). The fix of this PR can be seen by enabling
mangledNamestest, JvmName annotations and internal names should be handled now.Note that light class still won't handle inline names.