Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BloomFilter.bitSize() public #6923

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Siddharth1410
Copy link

@Siddharth1410 Siddharth1410 commented Jan 16, 2024

PR to fix issue - #6866

@Siddharth1410 Siddharth1410 marked this pull request as ready for review January 16, 2024 08:54
AmitPatil05 added a commit to AmitPatil05/guava that referenced this pull request Feb 3, 2024
@chaoren chaoren added type=addition A new feature package=hash status=triaged P3 java Pull requests that update Java code labels Feb 13, 2024
@@ -214,7 +214,7 @@ public long approximateElementCount() {

/** Returns the number of bits in the underlying bit array. */
@VisibleForTesting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that we've made it public should we remove the annotation?

The documentation states the following

Do not use this interface for public or protected declarations: it is a fig leaf for bad design, and it does not prevent anyone from using the declaration---and experience has shown that they will. If the method breaks the encapsulation of its class, then its internal representation will be hard to change. Instead, use RestrictedApiChecker , which enforces fine-grained visibility policies.

@@ -215,7 +215,7 @@ public long approximateElementCount() {

/** Returns the number of bits in the underlying bit array. */
@VisibleForTesting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@SAIVARDHAN15
Copy link

hey, anyone working on #6923? ,
if not, I am glad to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code P3 package=hash status=triaged type=addition A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants