Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action version comments in GitHub workflow files #7068

Closed
Marcono1234 opened this issue Mar 4, 2024 · 1 comment · Fixed by #7083
Closed

Add action version comments in GitHub workflow files #7068

Marcono1234 opened this issue Mar 4, 2024 · 1 comment · Fixed by #7083

Comments

@Marcono1234
Copy link
Contributor

The GitHub workflow files of Guava currently refer to action versions by commit hash, for example:

- name: 'Check out repository'
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11

While this is good from a security perspective, it makes it difficult at a glance to see which version number (such as "v1.2.3") of that action is used.

What do you think about adding version comments, such as # v1.2.3, behind the commit hashes? It seems Dependabot will automatically update those comments.

@cpovirk
Copy link
Member

cpovirk commented Mar 4, 2024

Thanks, adding them should be fine. I dropped them when I switched to hashes because it was ever so slightly easier and because it's not as if there is a runtime check that verifies that the comment is actually accurate. Now, I don't think that the latter is a practical concern because the values are always generated by Dependabot, which we trust. On the other hand, probably nothing we do here is of great practical significance because... we trust Dependabot to update as as soon as a problem is identified (and/or for security advisories to recognize the vulnerable version by its hash, I hope, or at least I hope that it doesn't trust the comment!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants