Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spotless plugin #2537

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Conversation

MaicolAntali
Copy link
Contributor

Purpose

Add the spotless plugins to enforce the Google Java Style Guide.

Description

Related with #2284

Excludes:
- Java17RecordTest.java
- Java17RecordReflectionTest.java
@MaicolAntali MaicolAntali mentioned this pull request Nov 7, 2023
9 tasks
pom.xml Outdated
Comment on lines 140 to 152
<formats>
<format>
<includes>
<include>*.md</include>
<include>.gitignore</include>
</includes>
<trimTrailingWhitespace/>
<endWithNewline/>
<indent>
<spaces>true</spaces>
<spacesPerTab>4</spacesPerTab>
</indent>
</format>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the <format> section, let me know if you prefer to remove it (or remove the .md)

pom.xml Outdated Show resolved Hide resolved
@eamonnmcmanus
Copy link
Member

Is this ready to merge?

@MaicolAntali
Copy link
Contributor Author

If we want keep the <format> section, yes

Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. We can always adjust this later as needed.

Thanks again for doing this!

@eamonnmcmanus eamonnmcmanus merged commit d58e2c9 into google:main Nov 13, 2023
9 checks passed
@MaicolAntali MaicolAntali deleted the add-spotless-plugin branch November 13, 2023 16:28
@Marcono1234 Marcono1234 mentioned this pull request Nov 14, 2023
9 tasks
tibor-universe pushed a commit to getuniverse/gson that referenced this pull request Sep 14, 2024
* Adds the `spotless` plugin

* Excludes `Java17` files

Excludes:
- Java17RecordTest.java
- Java17RecordReflectionTest.java

* Fixes formatting in `pom.xml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants