Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Error Prone to the maven-compiler-plugin #2308

Merged
merged 10 commits into from
Feb 6, 2023
Merged

Adds Error Prone to the maven-compiler-plugin #2308

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a5a5e52
Adds Error Prone to the `pom.xml`
MaicolAntali Feb 1, 2023
9910d47
Adds Error Prone annotations to avoid compiling errors
MaicolAntali Feb 1, 2023
61771d0
Adds profile to run Error Prone in JDK8
MaicolAntali Feb 1, 2023
d14d61f
Revert "Adds profile to run Error Prone in JDK8"
MaicolAntali Feb 1, 2023
0be7801
Fix Error Prone warn
MaicolAntali Feb 3, 2023
4fa7b35
Add comment to `pom.xml`
MaicolAntali Feb 4, 2023
f1206b7
Fix the `@SuppressWarnings("GetClassOnClass")`
MaicolAntali Feb 6, 2023
fa641c0
Replace the Error Prone link in the `pom.xml`
MaicolAntali Feb 6, 2023
5faa528
Disable Error Prone with jdk-15`
MaicolAntali Feb 6, 2023
89f6e39
Remove a new-line in `pom.xml`
MaicolAntali Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds profile to run Error Prone in JDK8
  • Loading branch information
@MaicolAntali
MaicolAntali committed Feb 1, 2023
commit 61771d0da55003ea5bc8c6f086d925aec583c9a2
21 changes: 21 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,27 @@
</build>

<profiles>
<!-- using github.com/google/error-prone-javac is required when running on JDK 8 -->
<profile>
<id>jdk8</id>
<activation>
<jdk>1.8</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<fork>true</fork>
<compilerArgs combine.children="append">
<arg>-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${maven.compiler.release}/javac-${maven.compiler.release}.jar</arg>
</compilerArgs>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<!-- Profile defining additional plugins to be executed for release -->
<profile>
<id>release</id>
Expand Down