make healthchecks optional

[sroettger]

a bunch of hacky changes to make it optional to deploy healthchecks
PTAL

[sroettger]

I removed the files from k8s/.base and autogenerate them now in .gen via the Makefiles.
The chain of kustomize files is then

• k8s/deployment (written by the challenge creator)
• .gen/k8s/deployment (generated by the makefile
• ../kctf-conf/base/k8s/deployment-with-healthcheck (optional based on the generated one above)
• ../kctf-conf/base/k8s/deployment

[sirdarckcat]

Since we know if HEALTHCHECK is true since the beginning, could we instead do:

ifeq ($(HEALTCHECK),true)
    .healtcheck-maybe: .healthcheck-enabled
else
    .healthcheck-maybe: .healthcheck-disabled
endif

https://ftp.gnu.org/old-gnu/Manuals/make-3.79.1/html_chapter/make_7.html

[sroettger]

PTAL, I'm using ifeq everywhere now

[sirdarckcat]

FYI (since you removed the ifs and you only have for loops left):
instead of a bash for loop here, I think you could have a Makefile for loop.

$(foreach resource,deployment service hpa,kubectl get $(resource) && kubectl delete $(resource))

https://www.gnu.org/software/make/manual/html_node/Foreach-Function.html

You can make this more elegant (example) if readability was a concern.

Another option is to use xargs like this:

echo deployment service hpa | xargs echo "kubectl get {} && kubectl delete {}" | sh

And a few other ways. Not the most elegant, however, so up to you.

This and below would allow you to avoid bash mode.