fix: drag cursor being incorrect for flyout blocks #8107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8102
Proposed Changes
Makes it so that blocks in the flyout have the
blocklyDraggableCSS class, even though they aren't actually draggable. The flyout detects a drag, duplicates the block, and then starts a drag on the new block.Reason for Changes
Buggy fixing.
Test Coverage
Manually tested and all tests pass.
Documentation
N/A
Additional Information
I'm not 100% sure that we actually want blocks in the flyout to have the
blocklyDraggableclass since they are draggable but also kind of aren't. But we can deal with that in V12 with the CSS refactor.