Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds _cvd-executor to the kvm group. #185

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Adds _cvd-executor to the kvm group. #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/debian/cuttlefish-orchestration.postinst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ case "$1" in
then
adduser --system --disabled-password --disabled-login --home /var/empty \
--no-create-home --quiet --force-badname --ingroup cvdnetwork _cvd-executor
usermod -aG kvm _cvd-executor
Comment on lines 16 to +17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using adduser's --ingroup makes cvdnetwork the primary group of the user. You probably don't want this, so it should be in a usermod line like kvm.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good point, let's doing it in a new PR specific to this concern.

fi
esac

Expand Down