Use system pybind11 and absl when available #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbobry
reviewed
Dec 18, 2022
tree/CMakeLists.txt
Outdated
| set(ABSEIL_CMAKE_ARGS | ||
| ${ABSEIL_CMAKE_ARGS} | ||
| "-DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES}") | ||
| find_package(pybind11 CONFIG) |
There was a problem hiding this comment.
Can we require a minimal pybind11 version here?
There was a problem hiding this comment.
For example, it compiles with 2.10.4.
find_package(pybind11 2.10.4 REQUIRED CONFIG)There was a problem hiding this comment.
Sorry for delay - updated, PTAL.
|
@superbobry bumping this. I'll fork if needed, but would prefer to use your version since it should already be done. |
Current CMakeLists.txt always downloads and builds `pybind11` and `absl` which conflicts with packaging best practices in some of the distributions. This change uses system libraries (if available) and falls back to the old behavior (if not).
|
thank you @ndl. |
superbobry
approved these changes
Aug 28, 2024
copybara-service
bot
merged commit 63f25d4
into
google-deepmind:master
2 of 28 checks passed
|
Thanks! |
|
thank you so much @superbobry! |
|
BTW - can confirm this works as expected. |
|
Now we just need a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current CMakeLists.txt always downloads and builds
pybind11andabslwhich conflicts with packaging best practices in some of the distributions. This change uses system libraries (if available) and falls back to the old behavior (if not).Note: it's better to view the diffs with white space changes ignored, than it's much more clear than the change is just a couple lines of code.