no need to copy objects when annotated #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I suppose this does not improve the compilation performance but your program generation code? How large is the speedup?
I'm slightly hesitant about this change because it looks like something that might introduce silent bugs. I have to think a bit more whether something can break here.
If we make this change: we can also remove .copy and the dependency on copy.
|
I've modified the doc string and removed the copy methods and dependency, at the time of removing this, it took around 30% of compilation time just on copy operations, however some were large programs |
david-lindner
approved these changes
Jan 30, 2024
david-lindner
requested changes
Jan 30, 2024
|
I have removed the tests for copy() and copying when annotating, we could always keep the copy method and keep the copy tests? |
david-lindner
approved these changes
Feb 7, 2024
david-lindner
requested changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to copy annotations, this is expensive