Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: document how to build a specific version of protoc-gen-go #764

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

jjlin
Copy link
Contributor

@jjlin jjlin commented Nov 28, 2018

If your code is locked to a specific version of github.com/golang/protobuf (e.g., 1.2.0), the default suggestion of go get -u github.com/golang/protobuf/protoc-gen-go may end up building and installing an incompatible version of protoc-gen-go (e.g., as introduced by https://github.com/golang/protobuf/blame/8d0c54c1/proto/proto3_proto/proto3.pb.go#L23).

Provides a workaround for #738.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jjlin
Copy link
Contributor Author

jjlin commented Nov 28, 2018

The last build apparently failed for transient network reasons; closed/reopened to retrigger.

@dsnet
Copy link
Member

dsnet commented Nov 28, 2018

Heh, funny trick closing/opening issue to re-trigger Travis.

@dsnet
Copy link
Member

dsnet commented Nov 28, 2018

Thank you for the PR.

@dsnet dsnet merged commit 1d3f30b into golang:master Nov 28, 2018
lfittl added a commit to pganalyze/collector that referenced this pull request Nov 30, 2018
@golang golang locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants