You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split off from discussion #18678, there referred to as "2".
Plan is to add a new internal-use flag to the compiler, -needversion,
and the compiler dies with a useful error if its own runtime.Version
does not match the passed in flag. When invoking the compiler,
the go command would pass -needversion with its own runtime.Version.
The check would then detect when the go command and the compiler
disagree about the Go toolchain version, which happens (to sometimes
mysterious effect) when the first 'go' in $PATH does not match the
$GOROOT environment setting.
The text was updated successfully, but these errors were encountered:
The check that the go tool version matched the go compiler version was
too aggressive and didn't cover the bootstrapping case with make.bash.
We never noticed because we never had a VERSION file in place.
Repro:
$ echo "go1.9beta1" > $GOROOT/VERSION
$ cd $GOROOT/src
$ ./make.bash
No test, because x/build/cmd/release catches it.
Updates #19064Fixes#20674
Change-Id: Ibdd7a92377f4cc77d71ed548f02d48bde6550f67
Reviewed-on: https://go-review.googlesource.com/45778
Reviewed-by: Chris Broadfoot <[email protected]>
Split off from discussion #18678, there referred to as "2".
Plan is to add a new internal-use flag to the compiler, -needversion,
and the compiler dies with a useful error if its own runtime.Version
does not match the passed in flag. When invoking the compiler,
the go command would pass -needversion with its own runtime.Version.
The check would then detect when the go command and the compiler
disagree about the Go toolchain version, which happens (to sometimes
mysterious effect) when the first 'go' in $PATH does not match the
$GOROOT environment setting.
The text was updated successfully, but these errors were encountered: