Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcode Lookup is Nondeterministic when no Obvious Output Format variant #7774

Closed
theory opened this issue Oct 4, 2020 · 1 comment · Fixed by #8462
Closed

Shortcode Lookup is Nondeterministic when no Obvious Output Format variant #7774

theory opened this issue Oct 4, 2020 · 1 comment · Fixed by #8462
Labels
Bug Outdated
Milestone
v0.83

Comments

@theory
Copy link
Contributor

theory commented Oct 4, 2020 

$ hugo version
Hugo Static Site Generator v0.75.1/extended darwin/amd64 BuildDate: unknown

Does this issue reproduce with the latest release?

Yes

Issue

My blog project has two output formats for articles, html and text. I've therefore created two variants of a figure shortcode, figure.html and figure.text. My HTML site renders okay, using the html shortcode for pages and lists, but for my feeds, it sometimes renders figure in the feed using the figure.html and sometimes using figure.text. It's pretty annoying when it uses figure.text.

I think it should either complain that there isn't an appropriate shortcode for the format, or else default to HTML (maybe with a warning?).

Community discussion
theory added a commit to theory/justatheory that referenced this issue Oct 4, 2020
@theory
Add JSON and Atom figure shortcodes
789dad5 
So that it doesn't pick HTML or text randomly (ref gohugoio/hugo#7774).
@bep bep added the Bug label Oct 4, 2020
@bep bep modified the milestones: v0.76, v0.77 Oct 4, 2020
@bep bep modified the milestones: v0.77, v0.78 Oct 30, 2020
@bep bep modified the milestones: v0.78, v0.83 Apr 23, 2021
@bep bep mentioned this issue Apr 23, 2021
Merged
bep added a commit to bep/hugo that referenced this issue Apr 23, 2021
@bep
Make the shortcode template lookup for output formats stable
e78df00 
Fixes gohugoio#7774
@bep bep closed this as completed in #8462 Apr 23, 2021
bep added a commit that referenced this issue Apr 23, 2021
@bep
Make the shortcode template lookup for output formats stable
0d86a32 
Fixes #7774
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Outdated
Projects
None yet
Milestone
v0.83
Development

Successfully merging a pull request may close this issue.

Make the shortcode template lookup for output formats stable bep/hugo
2 participants
@theory @bep