Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new default 'search score' sorting method for plugin search #1882

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

nebel
Copy link
Contributor

@nebel nebel commented Jul 2, 2024

Adds a new sorting option "Search score" to the plugin installer window. The window now starts in "adaptive" mode when opened, and in this mode it will switch between "Search score" and "Alphabetical" based on whether or not there's text in the search box.

Selecting an entry from the dropdown manually will disable adaptive mode until the window is closed. It's also possible to select "Search score" manually as long as there's text in the search box. If "Search score" is selected manually but no text is entered, it will sort alphabetically.

I'm not sure how to handle the new localization needed for the "Search score" string or if we want to name it something more user friendly (e.g. "Best match"?). Please let me know!

@nebel nebel requested a review from a team as a code owner July 2, 2024 17:09
@goaaats
Copy link
Member

goaaats commented Jul 3, 2024

Looks great, thanks!

@goaaats goaaats merged commit 583c007 into goatcorp:master Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants