Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix payload validations in app tests #497

Merged
merged 2 commits into from
May 20, 2016
Merged

Fix payload validations in app tests #497

merged 2 commits into from
May 20, 2016

Conversation

ikawaha
Copy link
Contributor

@ikawaha ikawaha commented May 20, 2016

gen_app generates some BadRequest test, but calling a BadRequest test with invalid payload causes panic.

This change is intended to pass tests with invalid payload when expected BadRequest.

@raphael
Copy link
Member

raphael commented May 20, 2016

Makes sense, thank you. @aslakknutsen may want to take a look too.

@aslakknutsen
Copy link
Contributor

Makes perfect sense! :)

@raphael raphael merged commit 15a87d5 into goadesign:master May 20, 2016
@ikawaha ikawaha deleted the fix/gen_app/payload_validation_20160519 branch May 20, 2016 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikawaha @raphael @aslakknutsen