Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes undue propagation of x-go-name to tags in AllOf serializer #2072

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

fredbi
Copy link
Contributor

@fredbi fredbi commented Oct 2, 2019

Signed-off-by: Frederic BIDON [email protected]

* fixes go-swagger#2071
* added unit test on generated model

Signed-off-by: Frederic BIDON <[email protected]>
@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #2072 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2072      +/-   ##
==========================================
- Coverage   80.34%   80.31%   -0.03%     
==========================================
  Files          46       46              
  Lines        8281     8281              
==========================================
- Hits         6653     6651       -2     
- Misses       1111     1112       +1     
- Partials      517      518       +1
Impacted Files Coverage Δ
generator/structs.go 74.1% <0%> (-1.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5499abf...4475a34. Read the comment docs.

@fredbi fredbi requested a review from casualjim October 2, 2019 07:49
@casualjim casualjim merged commit 5344aef into go-swagger:master Oct 2, 2019
BertrandGouny added a commit to osixia/go-swagger that referenced this pull request Oct 22, 2019
[Full Changelog](go-swagger/go-swagger@v0.20.1...v0.21.0)

**Implemented enhancements:**

- Add warning messages for inconsistent parameter types and validations [\go-swagger#2069](go-swagger#2069)

**Fixed bugs:**

- JSON tags are not honored in case of allOf. [\go-swagger#2071](go-swagger#2071)

**Closed issues:**

- How to register a handler for the server? [\go-swagger#2083](go-swagger#2083)
- Flatten before serve [\go-swagger#2078](go-swagger#2078)
- Additional keys in response model [\go-swagger#2073](go-swagger#2073)
- Go v0.20.0: checksum mismatch when using GOPROXY=direct [\go-swagger#2065](go-swagger#2065)
- Code generation fails when swagger is built with go1.13 [\go-swagger#2058](go-swagger#2058)
- feature: support custom swagger type [\go-swagger#1183](go-swagger#1183)

**Merged pull requests:**

- Add OpenAPI Terraform provider to 'Who is using this project?' section [\go-swagger#2084](go-swagger#2084) ([dikhan](https://github.com/dikhan))
- Add flag to allow overwriting protected templates [\go-swagger#2082](go-swagger#2082) ([dominikznidar](https://github.com/dominikznidar))
- Feat\(serve\) : Add flatten flag to serve command [\go-swagger#2079](go-swagger#2079) ([seblegall](https://github.com/seblegall))
- added contrib to the docker image [\go-swagger#2076](go-swagger#2076) ([ronnie-stratoscale](https://github.com/ronnie-stratoscale))
- Keep spec orders for mixin command [\go-swagger#2074](go-swagger#2074) ([BupycHuk](https://github.com/BupycHuk))
- fixes undue propagation of x-go-name to tags in AllOf serializer [\go-swagger#2072](go-swagger#2072) ([fredbi](https://github.com/fredbi))
- Provide example for configure command-line flags [\go-swagger#2068](go-swagger#2068) ([antonok](https://github.com/antonok))
- Add default flag support  `import "flags"` [\go-swagger#2067](go-swagger#2067) ([hisunwei](https://github.com/hisunwei))
- Added installation instructions through docker for windows users [\go-swagger#2061](go-swagger#2061) ([EliCDavis](https://github.com/EliCDavis))
- update go-openapi libraries for go 1.13 fix [\go-swagger#2059](go-swagger#2059) ([casualjim](https://github.com/casualjim))

\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
@fredbi fredbi deleted the fix-2071 branch November 25, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON tags are not honored in case of allOf.
2 participants