Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS provider for cloud.ru #1968

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Add DNS provider for cloud.ru #1968

merged 4 commits into from
Jul 27, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 24, 2023 •
edited
Loading

  • add a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment in your PR)
    Support for provider: cloud.ru #1966 (comment)
  • pass the linter
  • do go mod tidy

Ping @mrJDoe, can you run the command (with your domain, email, and credentials)?

Closes #1966

@ldez ldez mentioned this pull request Jul 24, 2023
Closed
5 tasks
@ldez ldez removed state/need-user-tests Need users to test functionality contrib/waiting-for-feedback labels Jul 25, 2023
@ldez ldez added this to the v4.14 milestone Jul 25, 2023
@ldez ldez marked this pull request as ready for review July 25, 2023 14:23
@ldez ldez requested a review from dmke July 25, 2023 14:24
@dmke
Copy link
Member

dmke commented Jul 25, 2023

Will have a look later.

dmke
dmke approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@dmke dmke mentioned this pull request Jul 25, 2023
Merged
@ldez ldez enabled auto-merge (squash) July 27, 2023 10:45
@ldez ldez merged commit ae78237 into go-acme:master Jul 27, 2023
10 checks passed
@ldez ldez deleted the feat/cloudru branch July 27, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/dnsprovider enhancement
Milestone
v4.14
Development

Successfully merging this pull request may close these issues.

Support for provider: cloud.ru
2 participants
@ldez @dmke