Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for Derak Cloud #1909

Merged
merged 3 commits into from
May 5, 2023
Merged

Add DNS provider for Derak Cloud #1909

merged 3 commits into from
May 5, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented May 1, 2023

  • have a homogeneous design with the other providers
  • pass the linter
  • do go mod tidy
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
$ DERAK_API_KEY="xxxx" \
./lego --email [email protected] --dns derak --domains *.example.com --domains example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
2023/05/02 00:45:41 No key found for account [email protected]. Generating a P256 key.
2023/05/02 00:45:41 Saved key to /home/ldez/sources/go/src/github.com/go-acme/lego/dist/.lego/accounts/acme-staging-v02.api.letsencrypt.org/[email protected]/keys/[email protected]
2023/05/02 00:45:42 Please review the TOS at https://letsencrypt.org/documents/LE-SA-v1.3-September-21-2022.pdf
Do you accept the TOS? Y/n
y
2023/05/02 00:45:43 [INFO] acme: Registering account for [email protected]
!!!! HEADS UP !!!!

Your account credentials have been saved in your Let's Encrypt
configuration directory at "/home/ldez/sources/go/src/github.com/go-acme/lego/dist/.lego/accounts".

You should make a secure backup of this folder now. This
configuration directory will also contain certificates and
private keys obtained from Let's Encrypt so making regular
backups of this folder is ideal.
2023/05/02 00:45:44 [INFO] [*.example.com, example.com] acme: Obtaining bundled SAN certificate
2023/05/02 00:45:44 [INFO] [*.example.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/6320263384
2023/05/02 00:45:44 [INFO] [example.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/6320263394
2023/05/02 00:45:44 [INFO] [*.example.com] acme: use dns-01 solver
2023/05/02 00:45:44 [INFO] [example.com] acme: Could not find solver for: tls-alpn-01
2023/05/02 00:45:44 [INFO] [example.com] acme: Could not find solver for: http-01
2023/05/02 00:45:44 [INFO] [example.com] acme: use dns-01 solver
2023/05/02 00:45:44 [INFO] [*.example.com] acme: Preparing to solve DNS-01
2023/05/02 00:45:47 [INFO] [example.com] acme: Preparing to solve DNS-01
2023/05/02 00:45:50 [INFO] [*.example.com] acme: Trying to solve DNS-01
2023/05/02 00:45:50 [INFO] [*.example.com] acme: Checking DNS record propagation using [192.168.1.1:53 [2a02:842b:5a8:b601::1]:53]
2023/05/02 00:45:55 [INFO] Wait for propagation [timeout: 2m0s, interval: 5s]
2023/05/02 00:45:55 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:00 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:05 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:10 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:15 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:21 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:26 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:31 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:36 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:41 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:46 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:51 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:46:56 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:47:02 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:47:07 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2023/05/02 00:47:18 [INFO] [*.example.com] The server validated our request
2023/05/02 00:47:18 [INFO] [example.com] acme: Trying to solve DNS-01
2023/05/02 00:47:18 [INFO] [example.com] acme: Checking DNS record propagation using [192.168.1.1:53 [2a02:842b:5a8:b601::1]:53]
2023/05/02 00:47:23 [INFO] Wait for propagation [timeout: 2m0s, interval: 5s]
2023/05/02 00:47:28 [INFO] [example.com] The server validated our request
2023/05/02 00:47:28 [INFO] [*.example.com] acme: Cleaning DNS-01 challenge
2023/05/02 00:47:31 [INFO] [example.com] acme: Cleaning DNS-01 challenge
2023/05/02 00:47:34 [INFO] [*.example.com, example.com] acme: Validations succeeded; requesting certificates
2023/05/02 00:47:34 [INFO] Wait for certificate [timeout: 30s, interval: 500ms]
2023/05/02 00:47:35 [INFO] [*.example.com] Server responded with a certificate.

Note the wildcard domain is important.

Closes #1872

@ldez ldez added this to the v4.11 milestone May 1, 2023
@ldez ldez requested a review from dmke May 1, 2023 23:17
@ldez ldez force-pushed the feat/derak branch 2 times, most recently from be7faf2 to f37983e Compare May 2, 2023 16:14
@ldez ldez modified the milestones: v4.11, v4.12 May 2, 2023
@ldez ldez force-pushed the feat/derak branch 2 times, most recently from 10165d8 to f2df45d Compare May 2, 2023 20:44
@dmke
Copy link
Member

dmke commented May 4, 2023

Do you want to incorporate providers/dns/internal/errutils from #1868?

Otherwise, LGTM.

@ldez ldez merged commit 3d44184 into go-acme:master May 5, 2023
@ldez ldez deleted the feat/derak branch May 5, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for provider: Derak Cloud
2 participants