Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exoscale: migrate to API v2 endpoints #1682

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Conversation

kobajagi
Copy link
Contributor

This PR reworks exoscale DNS provider to use exoscale API v2 endpoints.

No changes from #1674

Live tests passing:

$ go test -v -count 1 ./providers/dns/exoscale 
=== RUN   TestNewDNSProvider
=== RUN   TestNewDNSProvider/success
=== RUN   TestNewDNSProvider/missing_credentials
=== RUN   TestNewDNSProvider/missing_access_key
=== RUN   TestNewDNSProvider/missing_secret_key
--- PASS: TestNewDNSProvider (0.00s)
    --- PASS: TestNewDNSProvider/success (0.00s)
    --- PASS: TestNewDNSProvider/missing_credentials (0.00s)
    --- PASS: TestNewDNSProvider/missing_access_key (0.00s)
    --- PASS: TestNewDNSProvider/missing_secret_key (0.00s)
=== RUN   TestNewDNSProviderConfig
=== RUN   TestNewDNSProviderConfig/success
=== RUN   TestNewDNSProviderConfig/missing_credentials
=== RUN   TestNewDNSProviderConfig/missing_api_key
=== RUN   TestNewDNSProviderConfig/missing_secret_key
--- PASS: TestNewDNSProviderConfig (0.00s)
    --- PASS: TestNewDNSProviderConfig/success (0.00s)
    --- PASS: TestNewDNSProviderConfig/missing_credentials (0.00s)
    --- PASS: TestNewDNSProviderConfig/missing_api_key (0.00s)
    --- PASS: TestNewDNSProviderConfig/missing_secret_key (0.00s)
=== RUN   TestDNSProvider_FindZoneAndRecordName
=== RUN   TestDNSProvider_FindZoneAndRecordName/Extract_root_record_name
=== PAUSE TestDNSProvider_FindZoneAndRecordName/Extract_root_record_name
=== RUN   TestDNSProvider_FindZoneAndRecordName/Extract_sub_record_name
=== PAUSE TestDNSProvider_FindZoneAndRecordName/Extract_sub_record_name
=== CONT  TestDNSProvider_FindZoneAndRecordName/Extract_root_record_name
=== CONT  TestDNSProvider_FindZoneAndRecordName/Extract_sub_record_name
--- PASS: TestDNSProvider_FindZoneAndRecordName (0.00s)
    --- PASS: TestDNSProvider_FindZoneAndRecordName/Extract_root_record_name (0.01s)
    --- PASS: TestDNSProvider_FindZoneAndRecordName/Extract_sub_record_name (0.03s)
=== RUN   TestLivePresent
--- PASS: TestLivePresent (8.92s)
=== RUN   TestLiveCleanUp
--- PASS: TestLiveCleanUp (5.01s)
PASS
ok      github.com/go-acme/lego/v4/providers/dns/exoscale       13.964s

@kobajagi
Copy link
Contributor Author

@ldez as advised in #1674, new PR is from my personal fork and not org.

@ldez ldez self-requested a review July 28, 2022 22:39
@ldez ldez added this to the v4.9 milestone Aug 4, 2022
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@ldez ldez enabled auto-merge (squash) August 4, 2022 14:23
@ldez ldez merged commit 791eb3c into go-acme:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants