Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unitialized values in plplot driver #1674

Conversation

GillesDuvert
Copy link
Contributor

unitialized values were crashing GDL on Apple (OSX not permitting such things anymore).

Unitialized values are seen with Valgrind and -Wuninitialized

This patch alone does not solve all problems on Apple M1

…h things anymore).

Unitialized values are seen with Valgrind and -Wuninitialized
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a11b0a0) 41.80% compared to head (06291d7) 41.80%.

❗ Current head 06291d7 differs from pull request most recent head 7c7d38d. Consider uploading reports for the commit 7c7d38d to get more accurate results

Files Patch % Lines
src/plplotdriver/deprecated_wxwidgets.cpp 0.00% 2 Missing ⚠️
src/plplotdriver/deprecated_wxwidgets_app.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1674   +/-   ##
=======================================
  Coverage   41.80%   41.80%           
=======================================
  Files         356      356           
  Lines       95208    95211    +3     
  Branches    19555    19555           
=======================================
+ Hits        39803    39805    +2     
- Misses      55405    55406    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GillesDuvert GillesDuvert merged commit 24a3deb into gnudatalanguage:master Nov 17, 2023
6 checks passed
@GillesDuvert GillesDuvert deleted the remove_unitialized_values_in_plplot_driver branch July 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant