Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of gaussfit named gaussfit2 #1602

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

BoudjemaaS
Copy link

No description provided.

@BoudjemaaS BoudjemaaS changed the title improved timestamp procedure and new tests New version of gaussfit named gaussfit2 May 30, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 37.15% and project coverage change: -0.81 ⚠️

Comparison is base (c94e31c) 41.83% compared to head (d6cddc7) 41.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
- Coverage   41.83%   41.02%   -0.81%     
==========================================
  Files         347      354       +7     
  Lines      108284    95097   -13187     
  Branches        0    19557   +19557     
==========================================
- Hits        45297    39011    -6286     
+ Misses      62987    56086    -6901     
Impacted Files Coverage Δ
src/FMTIn.cpp 15.81% <ø> (-1.49%) ⬇️
src/FMTIn.hpp 47.61% <ø> (+2.16%) ⬆️
src/FMTLexer.hpp 100.00% <ø> (ø)
src/FMTOut.cpp 43.79% <ø> (+0.86%) ⬆️
src/FMTOut.hpp 77.35% <ø> (+4.63%) ⬆️
src/FMTParser.hpp 50.00% <ø> (+27.77%) ⬆️
src/GDLInterpreter.hpp 49.23% <ø> (-0.14%) ⬇️
src/GDLLexer.hpp 59.09% <0.00%> (+4.74%) ⬆️
src/GDLParser.cpp 66.09% <ø> (-4.57%) ⬇️
src/GDLParser.hpp 75.00% <ø> (+0.92%) ⬆️
... and 79 more

... and 251 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Saynkas
Copy link
Contributor

Saynkas commented Jun 13, 2023

Codecov Report

Patch coverage: 37.15% and project coverage change: -0.81 warning

Comparison is base (c94e31c) 41.83% compared to head (acc026e) 41.02%.

Additional details and impacted files

umbrella View full report in Codecov by Sentry. loudspeaker Do you have feedback about the report comment? Let us know in this issue.

I'm starting to think codecov keeps comparing PRs to the last commit from before it broke 5 months ago and doesn't properly update, which would explain why @GillesDuvert had dozens of changed files a few days ago when that wasn't the case (compared to the version on the github, I wouldn't doubt it compared to the version from 5 months ago)

codecov says the base is the same commit in this PR as well as #1603 despite #1603 having been merged since : c94e31c, which is the last commit from before it broke https://app.codecov.io/gh/gnudatalanguage/gdl/commit/c94e31c34feaefd1793d4d313e06cbbb8117d185?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnudatalanguage (copypaste the link, clicking on it doesn't work)

cause unknown at the moment, checkout should take the latest github version by default, or so says the documentation

@GillesDuvert GillesDuvert merged commit 49ce983 into gnudatalanguage:master Aug 8, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants