See #23111: Use the common acceptsDocumentationSummary `DownloadTas…

…k` method definition git-svn-id: https://josm.openstreetmap.de/osmsvn/applications/editors/josm/plugins@36144 b9d5c4c9-76e1-0310-9c85-f3177eceb1e4
gla-rad · Sep 18, 2023 · 3061fe2 · 3061fe2
1 parent a28d1aa
commit 3061fe2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 23 deletions.
diff --git a/pmtiles/build.xml b/pmtiles/build.xml
@@ -7,7 +7,7 @@
     <!-- enter the SVN commit message -->
     <property name="commit.message" value="Commit message"/>
     <!-- enter the *lowest* JOSM version this plugin is currently compatible with -->
-    <property name="plugin.main.version" value="10580"/>
+    <property name="plugin.main.version" value="18830"/>
 
     <!-- Configure these properties (replace "..." accordingly).
          See https://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins

diff --git a/...ava/org/openstreetmap/josm/plugins/pmtiles/actions/downloadtasks/DownloadPMTilesTask.java b/...ava/org/openstreetmap/josm/plugins/pmtiles/actions/downloadtasks/DownloadPMTilesTask.java
@@ -17,7 +17,6 @@
 import org.openstreetmap.josm.data.Bounds;
 import org.openstreetmap.josm.gui.MainApplication;
 import org.openstreetmap.josm.gui.progress.ProgressMonitor;
-import org.openstreetmap.josm.io.XmlWriter;
 import org.openstreetmap.josm.plugins.pmtiles.data.imagery.PMTilesImageryInfo;
 import org.openstreetmap.josm.plugins.pmtiles.gui.layers.PMTilesImageLayer;
 import org.openstreetmap.josm.plugins.pmtiles.gui.layers.PMTilesMVTLayer;
@@ -72,27 +71,6 @@ public boolean acceptsUrl(String url, boolean isRemotecontrol) {
         return url.endsWith(".pmtiles");
     }
 
-    @Override
-    public String acceptsDocumentationSummary() {
-        // I think this should be a "default" implementation in DownloadTask
-        StringBuilder buff = new StringBuilder(128)
-                .append("<tr><td>")
-                .append(getTitle())
-                .append(":</td><td>");
-        String[] patterns = getPatterns();
-        if (patterns.length > 0) {
-            buff.append("<ul>");
-            for (String pattern: patterns) {
-                buff.append("<li>")
-                        .append(XmlWriter.encode(pattern))
-                        .append("</li>");
-            }
-            buff.append("</ul>");
-        }
-        buff.append("</td></tr>");
-        return buff.toString();
-    }
-
     @Override
     public String getTitle() {
         return tr("Add PMTiles layer");