Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect RAM constraints imposed by Linux cgroups #1888

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

henrymercer
Copy link
Contributor

This updates the Action's RAM calculation to incorporate RAM constraints imposed by Linux cgroups, for example when running in a Docker container on Linux.

We support constraints from both cgroups v1 and v2.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 15, 2023 17:10
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! Could we add a comment indicating that once the relevant NodeJS fix is in we'd be able to remove this workaround?

@henrymercer
Copy link
Contributor Author

NIce! Could we add a comment indicating that once the relevant NodeJS fix is in we'd be able to remove this workaround?

Yes, I'll do so as follow up so I can get this out.

@henrymercer henrymercer merged commit 4254f3a into main Sep 18, 2023
345 checks passed
@henrymercer henrymercer deleted the henrymercer/constrained-ram branch September 18, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants