-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack Welcomebot on AWS Lambda #1017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
- Coverage 31.95% 31.63% -0.33%
==========================================
Files 106 105 -1
Lines 7244 7464 +220
Branches 942 1003 +61
==========================================
+ Hits 2315 2361 +46
- Misses 4821 4992 +171
- Partials 108 111 +3
Continue to review full report at Codecov.
|
Additionally, this PR will allow us to monitor the lambda and ensure it's running versus not knowing if the |
did not test, but mostly LGTM two things
after that, feel free to ship and pls test in prod once this is live! |
@owocki I don't have access to manage our bots. Any way I can get access to modify the scope of the welcomebot? |
@mbeacom theres no 'scope' to manage. its just a legacy token issued via https://api.slack.com/custom-integrations/legacy-tokens you can get the token by checking out the |
@owocki The event driven bot needs a verification token and a bot token. I will need you or @coderberry to provide a verification token for the specified bot and ensure it's subscribed to https://github.com/slackapi/python-slack-events-api#--app-setup |
Should be able to use: https://gitcoincommunity.slack.com/apps/AAG4J9934-welcomebot |
…946-296 * 'fix-946-296' of github.com:CuriousLearner/web: Slack Welcomebot on AWS Lambda (gitcoinco#1017) default to 'any' being checked Add user tracking to rollbar js config fixes gitcoinco#1040 (gitcoinco#1043) 2 days at a time max time gives staff the ability to remove users from a bounty (gitcoinco#1042) one more try slower new d3 viz show nodes over time on graph
* 'master' of https://github.com/gitcoinco/web: (46 commits) Fix gitcoinco#1063 - Fix work submitted formatting for gitcoinbot comments Fix logging dt Disable pin since we only use runserver locally Add autoreload on .env save and limit provisioning send a list of old bounties at the footer of the new bounty email too only show open bounties in new bounty email only send feedback emails on mainnet https://rollbar.com/gitcoin/gitcoin/items/642/ copy submit message was formatted funny fix for TypeError: unsupported operand type(s) for +: 'BountyQuerySet' and 'BountyQuerySet' logs abandoned work and prevents users from starting new work bc of it (gitcoinco#1039) Slack Welcomebot on AWS Lambda (gitcoinco#1017) default to 'any' being checked Add user tracking to rollbar js config fixes gitcoinco#1040 (gitcoinco#1043) 2 days at a time max time gives staff the ability to remove users from a bounty (gitcoinco#1042) one more try ...
Description
The goal of this PR is to offload the functionality of
slack_welcomebot.py
management command to avoid high CPU utilization (95%) on the production servers by offloading the welcomebot to AWS Lambda and use the Slack Events API versus the RTM API.Checklist
Affected core subsystem(s)
welcomebot, slack
Testing
Tested on private slack community and AWS account.
Refers/Fixes
Refs: #874, #1012