If ssh-agent.exe is running, it prevents upgrades of Git for Windows #920
Assignees
Milestone
Comments
|
For what it's worth, ssh-pageant.exe should probably be handled in the same way. It has essentially the same impact and is reported the same way when upgrading, although I wouldn't expect to find the ssh-add.exe and/or second agent processes in that case. |
dscho
added a commit
to dscho/build-extra
that referenced
this issue
Nov 1, 2016
When running Git for Windows' installer, it is pretty obvious that any running SSH agent that needs to be potentially upgraded needs to be stopped. So let's do just that. This fixes git-for-windows/git#920 Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to git-for-windows/build-extra
that referenced
this issue
Nov 1, 2016
when upgrading Git for Windows, SSH agent processes [are now auto-terminated](git-for-windows/git#920). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As we know that
ssh-agent.exeis a daemon, we should simply kill it and move on.The main problem I had with this is that it appears as if there may be an
ssh-add.exerunning at the same time, and a secondssh-agent.exeprocess, both of which are not shown by MSYS2's ownps -W. But the Task Manager sees them and the user can kill them interactively.Hopefully we can teach the installer to kill silently any of Git's own
ssh-agent.exeand/orssh-add.exe. The chances are good: We already show such processes successfully in the wizard page that prevents the installer from running, after all.The text was updated successfully, but these errors were encountered: