installer: when spawning cmd, disable AutoRun
#312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the documentation, usually `AutoRun` steps specified via the registry (e.g. `Software\Microsoft\Command Processor\AutoRun`) are run when calling `cmd.exe`, unless the `/D` option is used: https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/cmd This can lead to problems when we use `cmd.exe` for the benefit of redirecting the output to a file: under certain circumstances it can easily produce an error "The system cannot find the path specified." Let's use the `/D` to address this problem. This addresses git-for-windows/git#2384. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Oct 9, 2020
Git for Windows [can now be installed](#312) even with stale `AutoRun` registry entries (e.g. left-overs from a Miniconda installation). Signed-off-by: Johannes Schindelin <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some user setups have stale
AutoRunregistry entries (e.g. from a Miniconda installation). The symptom looks like this:The idea is to pass the
/Doption tocmd.exe, to prevent suchAutoRunentries from being attempted to run.This addresses git-for-windows/git#2384.