installer: allow Pseudo Console support to be re-disabled #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in git-for-windows/git#2729 (comment), when a user enabled support for Pseudo Consoles and then reinstalled to disable it, by mistake the Pseudo Console support would _still_ be enabled. The reason? We only write `/etc/git-bash.config` to enable the Pseudo Console support, but not when we disable it (because it is disabled by default, anyway). However, we failed to remove that file upon uninstall/upgrade. Signed-off-by: Johannes Schindelin <[email protected]>
|
I'll just merge this and let the Git Artifacts Pipeline build new installers, then test ;-) |
Closed
1 task
dscho
added a commit
that referenced
this pull request
Jul 2, 2020
Due to a bug, it was not possible to disable Pseudo Console support by reinstalling with the checkbox turned off, [which has been fixed](#299). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @satsuper in git-for-windows/git#2729 (comment), when a user enabled support for Pseudo Consoles and then reinstalled to disable it, by mistake the Pseudo Console support would still be enabled.
The reason? We only write
/etc/git-bash.configto enable the Pseudo Console support, but not when we disable it (because it is disabled by default, anyway). However, we failed to remove that file upon uninstall/upgrade.