car update controller & laravel test case back to normal

gibmyx · Oct 15, 2022 · f970e13 · f970e13
1 parent 1dcc365
commit f970e13
Show file tree

Hide file tree

Showing 13 changed files with 193 additions and 41 deletions.
diff --git a/routes/api/car/routes.php b/routes/api/car/routes.php
@@ -4,6 +4,7 @@
 
 Route::post('/car', Quicktrack\Car\Infrastructure\Controllers\Api\CarPostController::class);
 Route::get('/car/{id}', Quicktrack\Car\Infrastructure\Controllers\Api\CarGetController::class);
+Route::put('/car/{id}', Quicktrack\Car\Infrastructure\Controllers\Api\CarPutController::class);
 
 /* Route::middleware('auth:api')
     ->group(function () {

diff --git a/src/Quicktrack/Car/Application/Update/CarUpdater.php b/src/Quicktrack/Car/Application/Update/CarUpdater.php
@@ -17,6 +17,7 @@
 use Quicktrack\Car\Domain\ValueObjects\CarStatus;
 use Quicktrack\Car\Domain\ValueObjects\CarType;
 use Quicktrack\Car\Domain\ValueObjects\CarYear;
+use Shared\Domain\Errors;
 
 final class CarUpdater
 {
@@ -35,17 +36,19 @@ public function __invoke(
     {
         $car = ($this->finder)(new CarId($request->id()));
 
-        $car->changeBrand(new CarBrand($request->brand()));
-        $car->changeModel(new CarModel($request->model()));
-        $car->changeColor(new CarColor($request->color()));
-        $car->changeFuel(new CarFuel($request->fuel()));
-        $car->changeGearbox(new CarGearbox($request->gearbox()));
-        $car->changeKilometer(new CarKilometer($request->kilometer()));
-        $car->changePrice(new CarPrice($request->price()));
-        $car->changeType(new CarType($request->type()));
-        $car->changeYear(new CarYear($request->year()));
-        $car->changeStatus(new CarStatus($request->status()));
-
-        $this->repository->update($car);
+        if (! Errors::getInstance()->hasErrors()) {
+            $car->changeBrand(new CarBrand($request->brand()));
+            $car->changeModel(new CarModel($request->model()));
+            $car->changeColor(new CarColor($request->color()));
+            $car->changeFuel(new CarFuel($request->fuel()));
+            $car->changeGearbox(new CarGearbox($request->gearbox()));
+            $car->changeKilometer(new CarKilometer($request->kilometer()));
+            $car->changePrice(new CarPrice($request->price()));
+            $car->changeType(new CarType($request->type()));
+            $car->changeYear(new CarYear($request->year()));
+            $car->changeStatus(new CarStatus($request->status()));
+
+            $this->repository->update($car);
+        }
     }
 }
diff --git a/src/Quicktrack/Car/Infrastructure/Controllers/Api/CarPutController.php b/src/Quicktrack/Car/Infrastructure/Controllers/Api/CarPutController.php
@@ -0,0 +1,58 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Quicktrack\Car\Infrastructure\Controllers\Api;
+
+use Illuminate\Http\JsonResponse;
+use Illuminate\Http\Request;
+use App\Http\Controllers\Controller;
+use Quicktrack\Car\Application\Update\CarUpdater;
+use Quicktrack\Car\Application\Update\CarUpdaterRequest;
+use Shared\Domain\Errors;
+
+final class CarPutController extends Controller
+{
+    public function __construct(
+        private CarUpdater $updater
+    )
+    {
+    }
+
+    public function __invoke(string $id, Request $request): JsonResponse
+    {
+        ($this->updater)(new CarUpdaterRequest(
+            $id,
+            $request->input('brand'),
+            $request->input('model'),
+            $request->input('color'),
+            $request->input('fuel'),
+            $request->input('gearbox'),
+            $request->input('kilometer'),
+            $request->input('price'),
+            $request->input('type'),
+            $request->input('year'),
+            $request->input('status'),
+        ));
+
+        if (Errors::getInstance()->hasErrors()) {
+            return new JsonResponse(
+                [
+                    'ok' => false,
+                    'content' => [],
+                    'errors' => Errors::getInstance()->errorsMessage()
+                ], 
+                Errors::getInstance()->errorsCode()
+            );
+        }
+
+        return new JsonResponse(
+            [
+                'ok' => true,
+                'content' => [],
+                'errors' => []
+            ], 
+            JsonResponse::HTTP_OK
+        );
+    }
+}
diff --git a/src/Quicktrack/Car/Infrastructure/Persistence/EloquentCarRepository.php b/src/Quicktrack/Car/Infrastructure/Persistence/EloquentCarRepository.php
@@ -19,7 +19,11 @@ public function create(Car $car): void
 
     public function update(Car $car): void
     {
-        ModelsCar::update($car->toArray());
+        $car = ModelsCar::find($car->id()->value());
+
+        if ($car) {
+            $car->update($car->toArray());
+        }
     }
 
     public function find(CarId $carId): ?Car

diff --git a/tests/Feature/Quicktrack/Car/CarGetControllerTest.php b/tests/Feature/Quicktrack/Car/CarGetControllerTest.php
@@ -4,6 +4,7 @@
 
 use Tests\Shared\Infrastructure\Laravel\TestCase;
 use Tests\Unit\Quicktrack\Car\Domain\CarMother;
+use Tests\Unit\Shared\Domain\UuidMother;
 
 class CarGetControllerTest extends TestCase
 {
@@ -32,15 +33,14 @@ public function itShouldFindAnExistingCar()
      */
     public function errorsArrayShouldHaveDomainNotFoundException()
     {
-        $id = 'wrong-id';
+        $id = UuidMother::random();
         $response = $this->getJson("/api/car/{$id}");
 
         $response->assertStatus(400);
         $response->assertJson([
             'ok' => false,
             'content' => [],
             'errors' => [
-                "Invalid uuid",
                 "There's not any car with ID {$id}"
             ]
         ]);

diff --git a/tests/Feature/Quicktrack/Car/CarPutControllerTest.php b/tests/Feature/Quicktrack/Car/CarPutControllerTest.php
@@ -0,0 +1,48 @@
+<?php
+
+namespace Tests\Feature\Quicktrack\Car;
+
+use Tests\Shared\Infrastructure\Laravel\TestCase;
+use Tests\Unit\Quicktrack\Car\Domain\CarBrandMother;
+use Tests\Unit\Quicktrack\Car\Domain\CarMother;
+
+class CarPutControllerTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function itShouldFindAnUpdateAnExistingCar()
+    {
+        $car = CarMother::random();
+        $this->postJson('/api/car', $car->toArray());
+
+        $car->changeBrand(CarBrandMother::random());
+
+        $response = $this->putJson("/api/car/{$car->id()->value()}", $car->toArray());
+
+        $response->assertStatus(200);
+        $response->assertJson([
+            'ok' => true,
+            'content' => [],
+            'errors' => []
+        ]);
+    }
+
+    /**
+     * @test
+     */
+    public function errorsArrayShouldHaveDomainNotFoundException()
+    {
+        $car = CarMother::random();
+        $response = $this->putJson("/api/car/{$car->id()->value()}", $car->toArray());
+
+        $response->assertStatus(400);
+        $response->assertJson([
+            'ok' => false,
+            'content' => [],
+            'errors' => [
+                "There's not any car with ID {$car->id()->value()}"
+            ]
+        ]);
+    }
+}
diff --git a/tests/Feature/Quicktrack/Car/CarsGetController.php b/tests/Feature/Quicktrack/Car/CarsGetController.php
@@ -0,0 +1,48 @@
+<?php
+
+namespace Tests\Feature\Quicktrack\Car;
+
+use Tests\Shared\Infrastructure\Laravel\TestCase;
+use Tests\Unit\Quicktrack\Car\Domain\CarMother;
+use Tests\Unit\Shared\Domain\UuidMother;
+
+class CarsGetControllerTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function itShouldSearchAndFindAnExistingCar()
+    {
+        $car = CarMother::random();
+        $this->postJson('/api/car', $car->toArray());
+
+        $response = $this->getJson("/api/car/{$car->id()->value()}");
+
+        $response->assertStatus(200);
+        $response->assertJson([
+            'ok' => true,
+            'content' => [
+                'car' => $car->toArray()
+            ],
+            'errors' => []
+        ]);
+    }
+
+    /**
+     * @test
+     */
+    public function errorsArrayShouldHaveDomainNotFoundException()
+    {
+        $id = UuidMother::random();
+        $response = $this->getJson("/api/car/{$id}");
+
+        $response->assertStatus(400);
+        $response->assertJson([
+            'ok' => false,
+            'content' => [],
+            'errors' => [
+                "There's not any car with ID {$id}"
+            ]
+        ]);
+    }
+}
diff --git a/tests/Shared/Infrastructure/Laravel/TestCase.php b/tests/Shared/Infrastructure/Laravel/TestCase.php
@@ -4,12 +4,10 @@
 
 use Illuminate\Foundation\Testing\DatabaseTransactions;
 use Shared\Domain\Errors;
-use Tests\CreatesApplication;
 use Tests\TestCase as LaravelTestCase;
 
 abstract class TestCase extends LaravelTestCase
 {
-    use CreatesApplication;
     use DatabaseTransactions;
 
     protected function tearDown(): void

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -2,19 +2,10 @@
 
 namespace Tests;
 
-use Illuminate\Foundation\Testing\DatabaseTransactions;
 use Illuminate\Foundation\Testing\TestCase as BaseTestCase;
 use Shared\Domain\Errors;
 
 abstract class TestCase extends BaseTestCase
 {
     use CreatesApplication;
-    use DatabaseTransactions;
-
-    protected function tearDown(): void
-    {
-        if (Errors::getInstance()->hasErrors()) {
-            Errors::getInstance()->clear();
-        }
-    }
 }
diff --git a/tests/Unit/Quicktrack/Car/Application/Create/CarCreatorTest.php b/tests/Unit/Quicktrack/Car/Application/Create/CarCreatorTest.php
@@ -9,10 +9,11 @@
 use Quicktrack\Car\Domain\Contract\CarRepository;
 use Quicktrack\Car\Domain\Entity\Car;
 use Shared\Domain\Errors;
+use Tests\Shared\Infrastructure\Laravel\TestCase;
 use Tests\Unit\Quicktrack\Car\Domain\CarMother;
-use Tests\TestCase;
 
-final class CarCreatorTest extends TestCase {
+final class CarCreatorTest extends TestCase
+{
 
     /** 
      * @test

diff --git a/tests/Unit/Quicktrack/Car/Application/Find/CarFinderTest.php b/tests/Unit/Quicktrack/Car/Application/Find/CarFinderTest.php
@@ -10,12 +10,13 @@
 use Quicktrack\Car\Domain\Contract\CarRepository;
 use Quicktrack\Car\Domain\Entity\Car;
 use Shared\Domain\Errors;
+use Tests\Shared\Infrastructure\Laravel\TestCase;
 use Tests\Unit\Quicktrack\Car\Domain\CarMother;
-use Tests\TestCase;
 use Tests\Unit\Quicktrack\Car\Domain\CarIdMother;
 use Tests\Unit\Shared\Domain\UuidMother;
 
-final class CarFinderTest extends TestCase {
+final class CarFinderTest extends TestCase
+{
 
     /** 
      * @test

diff --git a/tests/Unit/Quicktrack/Car/Application/Search/CarSearcherTest.php b/tests/Unit/Quicktrack/Car/Application/Search/CarSearcherTest.php
@@ -7,7 +7,7 @@
 use Quicktrack\Car\Application\Search\CarSearcher;
 use Quicktrack\Car\Domain\Contract\CarRepository;
 use Quicktrack\Car\Domain\Entity\Car;
-use Tests\TestCase;
+use Tests\Shared\Infrastructure\Laravel\TestCase;
 use Tests\Unit\Quicktrack\Car\Domain\CarMother;
 use Tests\Unit\Quicktrack\Car\Domain\CarsMother;
 
@@ -22,15 +22,16 @@ public function itShouldFindOneActiveCar()
         $car2 = CarMother::withStatus('sold');
         $car3 = CarMother::withStatus('available');
         $response = CarsMother::create($car3);
+        $propValue = 'available';
 
         $repository = $this->createMock(CarRepository::class);
         $searcher = new CarSearcher($repository);
 
-        $this->shouldSearchByPropEqualTo($repository, 'status', 'available', $car1, $car2, $car3);
+        $this->shouldSearchByPropEqualTo($repository, 'status', $propValue, $car1, $car2, $car3);
 
         $this->assertEquals(
             $response,
-            ($searcher)(CarSearcherRequestMother::byStatus('available'))
+            ($searcher)(CarSearcherRequestMother::byStatus($propValue))
         );
     }
 
@@ -43,15 +44,16 @@ public function itShouldNotFindAnyActiveCar()
         $car2 = CarMother::withStatus('sold');
         $car3 = CarMother::withStatus('sold');
         $response = CarsMother::create();
+        $propValue = 'available';
 
         $repository = $this->createMock(CarRepository::class);
         $searcher = new CarSearcher($repository);
 
-        $this->shouldSearchByPropEqualTo($repository, 'status', 'available', $car1, $car2, $car3);
+        $this->shouldSearchByPropEqualTo($repository, 'status', $propValue, $car1, $car2, $car3);
 
         $this->assertEquals(
             $response,
-            ($searcher)(CarSearcherRequestMother::byStatus('available'))
+            ($searcher)(CarSearcherRequestMother::byStatus($propValue))
         );
     }
 

diff --git a/tests/Unit/Quicktrack/Car/Application/Update/CarUpdaterTest.php b/tests/Unit/Quicktrack/Car/Application/Update/CarUpdaterTest.php
@@ -6,16 +6,13 @@
 
 use PHPUnit\Framework\MockObject\MockObject;
 use Quicktrack\Car\Application\Update\CarUpdater;
-use Quicktrack\Car\Application\Update\CarUpdaterRequest;
 use Quicktrack\Car\Domain\Contract\CarRepository;
 use Quicktrack\Car\Domain\Entity\Car;
-use Shared\Domain\Exceptions\DomainNotExistsException;
+use Tests\Shared\Infrastructure\Laravel\TestCase;
 use Tests\Unit\Quicktrack\Car\Domain\CarMother;
-use Tests\TestCase;
-use Tests\Unit\Quicktrack\Car\Domain\CarIdMother;
-use Tests\Unit\Shared\Domain\UuidMother;
 
-final class CarUpdaterTest extends TestCase {
+final class CarUpdaterTest extends TestCase
+{
     /**
      * @test
      */