Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spv-out] Cache constant composites #2257

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

evahop
Copy link
Contributor

@evahop evahop commented Feb 20, 2023

Updates cached_constants to include composites.

@codecov-commenter
Copy link

Codecov Report

Merging #2257 (7970d1a) into master (dce689c) will decrease coverage by 0.24%.
The diff coverage is 52.94%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2257      +/-   ##
==========================================
- Coverage   82.25%   82.02%   -0.24%     
==========================================
  Files          80       80              
  Lines       42946    43161     +215     
==========================================
+ Hits        35325    35401      +76     
- Misses       7621     7760     +139     
Impacted Files Coverage Δ
src/front/wgsl/parse/mod.rs 88.28% <27.27%> (-7.79%) ⬇️
src/back/glsl/mod.rs 86.12% <100.00%> (+0.29%) ⬆️
src/back/hlsl/writer.rs 91.19% <100.00%> (ø)
src/back/spv/block.rs 91.23% <100.00%> (-0.13%) ⬇️
src/back/spv/mod.rs 95.19% <100.00%> (+0.02%) ⬆️
src/back/spv/writer.rs 96.70% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@teoxoy teoxoy mentioned this pull request Feb 20, 2023
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

@teoxoy teoxoy merged commit 60c0fc0 into gfx-rs:master Feb 20, 2023
@evahop evahop deleted the cache-const branch September 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants