debug(replay): Disregard replay duration for buffer mode #13923
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
force-pushed
the
debug-replay-disregard-replay-duration-for-buffer-mode
branch
from
a8f60e0
to
a8ad9a5
Compare
billyvg
commented
Oct 9, 2024
|
|
||
| // XXX: disregard durations for buffer mode for debug purposes | ||
| if (this.recordingMode !== 'buffer') { | ||
| return; |
There was a problem hiding this comment.
We only return (and not continue flushing) if in session mode and replay is too long or too short, otherwise setTag and continue flushing (for debugging purposes).
c298lee
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not intended to be merged for now, I would like to debug how/why errors are occurring so far disconnected from the snapshot checkout times.