fix: Sink should only be built after all source checkpoints are checked #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure is bogus. It's the accidentatlly introduced |
snork-alt
approved these changes
Mar 2, 2023
mediuminvader
added a commit
that referenced
this pull request
Mar 8, 2023
* chore: Move `SnapshottingDone` out of `Operation` so processors don't have to know it.(#1103) Also removed unused variants of `IngestionMessage` * feat: Switch to new cache if it processed enought number of operations (#1092) * chore: Don't create default eth provider (#1108) * chore: Remove an unused `Arc<RwLock>` (#1106) * fix: updated download_binary (#1107) * fix: updated download_binary * fix: updated download_binary * fix: updated download_binary * fix: updated download_binary * fix: updated download_binary * chore: Provide context to `ApiError`s (#1109) * tests: Run postgres tests on github actions and add snowflake support (#1037) * chore: Add installation to and remove docker instructions from README (#1110) * chore: Add remove unnecessary libraries remove (#1113) * chore: Don't run coverage on `pull_request_target` (#1116) * refactor: Simplify schemas fetch query (#1114) * refactor: Simplify schemas fetch query Fixes #1073 * Fix formatting * Fix tests * chore: Use 16 cores runner for coverage and release, 4 cores runner for lint (#1118) * chore: Use correct proto include path to avoid rebuilding every time (#1115) * fix: Sink should only be built after all source checkpoints are checked (#1112) * chore: Use `Dag::map_owned` instaed of `Dag::map` * chore: Remove context from `DagSchemas::EdgeType` * fix: Sink should only be built after all source checkpoints are checked * chore: Fix docker image publishing steps in release workflow (#1120) * remove unused dependency (#1122) The unused dependency of unixstring was causing build failure of native windows binary. Signed-off-by: Shailendra Thakur <[email protected]> * fix: Blue cache was counted with limit. Green cache didn't get picked up. (#1123) * fix: Define unique temp folder for aggregation tests (#1124) * fix: Define unique tmp dir * fix clippy * fix: groupby without measures were handled wrongly (#1127) * fix groupby withou measures * clippy fix * chore: Remove some unnecessary `clone`s (#1131) * chore: Don't clone whole config around the orchestrator * chore: Remove exccesive cloneing in `SourceBuilder` * chore: Remove excessive cloning in `PipelineBuilder` * chore: Remove excessive cloning in `Executor` * chore: clippy fix * refactor: Use rdkafka instead of kafka library * Format --------- Signed-off-by: Shailendra Thakur <[email protected]> Signed-off-by: Dario Pizzamiglio <[email protected]> Co-authored-by: Bei Chu <[email protected]> Co-authored-by: Chloe Kim <[email protected]> Co-authored-by: Shailendra Thakur <[email protected]> Co-authored-by: Dario Pizzamiglio <[email protected]> Co-authored-by: Matteo Pelati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.