Improve quoted-printable decoding #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hi @Maria-12648430, we merged a re-format of the code, which makes your PR conflict with master 😭 Could you rebase? |
It will probably have to wait until next week, but yes, sure 😊 |
Maria-12648430
force-pushed
the
improve_qp_decoding
branch
from
2a7fb67
to
d45c6e9
Compare
|
Well, I did it today ;) For reference, I rebased my branch on |
Maria-12648430
commented
Feb 11, 2022
| << | ||
| "=?ISO-8859-1?Q?a?=\n" | ||
| " =?ISO-8859-1?Q?b?=" | ||
| >>, |
There was a problem hiding this comment.
This was not part of my original PR, it got reformatted with the rest when I ran rebar3 fmt.
seriyps
approved these changes
Feb 11, 2022
|
Thanks @Maria-12648430 and sorry for the needed rebase. |
No worries 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves Quoted-Printable decoding by removing look-aheads in the remaining binary, and processing the entire body in one go instead of line by line.
This PR also includes a small (unrelated) nano-optimization/correction, replacing a list with a tuple in a case expression and the associated matches.