Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Operation] String escape/unescape functions #175

Merged
merged 4 commits into from
Aug 15, 2017

Conversation

mattnotmitt
Copy link
Collaborator

@mattnotmitt mattnotmitt commented Aug 7, 2017

Continuance of #62.

  • Merges Parse escaped string and Unescape string operations
  • Adds escaping of \t, \b and \f to Escape String to bring it closer in line with the output of Unescape string
  • Adds tests for both operations
  • Moves operations into the StrUtils namespace
  • Restructured examples

Unrelated to this PR, but I was wondering why we don't have an IRC channel or a gitter for this project considering its scale.

dalemyers and others added 4 commits January 23, 2017 21:39
These operations are useful for taking the contents of a string, and making it
suitable for use as a stand alone string. For example, in an IDE you might see
a string which is represented as: "Say \"Hello\"". The escaped double quotes
are shown to make it clear that they do not end the string, despite the fact
that they are not truly part of the string. In order to get the raw string, you
would need to copy this, then manually remove the backslashes. The new
String_.run_unescape operation does this automatically.

The String_.run_escape is the inverse. It allows you to take a string like the
one above, and paste it between two quotes without having to manually escape
it.
Updated to new project format
- Fixes examples
- Actually makes it work
- actually removed prev func
- shuffled some stuff around
@n1474335 n1474335 merged commit 6698a2a into gchq:master Aug 15, 2017
@n1474335
Copy link
Member

Really good to get this one tidied up. Thanks.

@mattnotmitt mattnotmitt deleted the features/string_escape_unescape branch August 15, 2017 17:48
@mattnotmitt
Copy link
Collaborator Author

Any thoughts on my unrelated point I mentioned in the PR text?

@n1474335
Copy link
Member

@artemisbot I'm following up on this and will let you know when we have a decision.

@n1474335
Copy link
Member

@artemisbot We have now created a Gitter room here, come and chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants