Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to plugin-offline for precaching preloaded fonts/json files #7092

Merged
merged 2 commits into from
Aug 7, 2018
Merged

Add support to plugin-offline for precaching preloaded fonts/json files #7092

merged 2 commits into from
Aug 7, 2018

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Aug 7, 2018 •
edited
Loading

Fixes #7066

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented Aug 7, 2018 •
edited
Loading

Deploy preview for gatsbyjs failed.

Built with commit e6dacac

https://app.netlify.com/sites/gatsbyjs/deploys/5b6962f2c6aed652851dd0ed

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented Aug 7, 2018 •
edited
Loading

Deploy preview for using-postcss-sass failed.

Built with commit e6dacac

https://app.netlify.com/sites/using-postcss-sass/deploys/5b6962f3c6aed652851dd0f9

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 7, 2018 •
edited
Loading

Deploy preview for using-drupal failed.

Built with commit e6dacac

https://app.netlify.com/sites/using-drupal/deploys/5b6962f3c6aed652851dd0f3

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented Aug 7, 2018 •
edited
Loading

Deploy preview for using-glamor failed.

Built with commit e6dacac

https://app.netlify.com/sites/using-glamor/deploys/5b6962f4c6aed652851dd102

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented Aug 7, 2018 •
edited
Loading

Deploy preview for gatsbygram failed.

Built with commit e6dacac

https://app.netlify.com/sites/gatsbygram/deploys/5b6962f2c6aed652851dd0f0

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented Aug 7, 2018 •
edited
Loading

Deploy preview for using-styled-components failed.

Built with commit e6dacac

https://app.netlify.com/sites/using-styled-components/deploys/5b6962f4c6aed652851dd105

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented Aug 7, 2018 •
edited
Loading

Deploy preview for image-processing failed.

Built with commit e6dacac

https://app.netlify.com/sites/image-processing/deploys/5b6962f4c6aed652851dd0ff

m-allanson
m-allanson previously approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎 👍

@KyleAMathews KyleAMathews merged commit 2a9a3a1 into master Aug 7, 2018
@KyleAMathews KyleAMathews deleted the preload branch August 7, 2018 09:37
@KyleAMathews
Copy link
Contributor Author

/cc @kkemple

@kkemple
Copy link
Contributor

kkemple commented Aug 7, 2018

oh this looks good! nice refactor!

@KyleAMathews KyleAMathews mentioned this pull request Aug 10, 2018
Closed
porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
@KyleAMathews @porfirioribeiro
Add support to plugin-offline for precaching preloaded fonts/json fil…
9acda5c 
…es (gatsbyjs#7092)

* Add support to plugin-offline for precaching preloaded fonts/json files

* Remove checked in compilied code and update gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-allanson m-allanson m-allanson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleAMathews @gatsbybot @kkemple @m-allanson