fix(gatsby): retry socket when connection closes #27060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: core
|
#25862 is the PR that added the @polarathene was the socket closing only meant to prevent console spam? It's unfortunate, but closing socket prevent socket.io from reconnect attempts and I would argue is worse DX than console spam? |
|
@pieh yes I think that was the only reason. There was a total of 3 sockets being treated like that, there shouldn't be any negative problems not closing the sockets, other than the browser continuing to poll when the dev server is not running. The core issue regarding Docker ports was resolved with an ENV var. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like we close socket.io ourselves when a disconnect happens. By default socket.io retries the connection using polling when the WebSocket fails and can recover.