Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: Add 'How we accidentally launched a popular Gatsby plugin' post #20103

Merged
merged 5 commits into from
Dec 16, 2019

Conversation

jariz
Copy link
Contributor

@jariz jariz commented Dec 12, 2019

Description

Republishing https://medium.com/oberonamsterdam/how-we-accidentally-launched-a-popular-gatsby-plugin-cfad9d94f415 for the Gatsby blog.
Pre-approved by @hashimwarren.

I hope it's formatted correctly, attempted to build the site locally but it crashed with exit code 1.
I also set the day of publication to today, but if you want it scheduled on another day @hashimwarren, please let me know.

@jariz jariz requested a review from a team as a code owner December 12, 2019 15:59
Copy link
Contributor

@hashimwarren hashimwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great article. Left a question and made a few changes

@hashimwarren hashimwarren added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 16, 2019
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is good with Hashim and it looks good to me as well, so I'll go ahead and merge! I updated a couple of relative links.

@AishaBlake AishaBlake merged commit d06e46a into master Dec 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/blog-gatsby-plugin-s3 branch December 16, 2019 18:34
@pieh
Copy link
Contributor

pieh commented Dec 17, 2019

I think we missed adding Jari to https://github.com/gatsbyjs/gatsby/blob/master/docs/blog/author.yaml

Because of that we are failing to build .org currently

@jariz
Copy link
Contributor Author

jariz commented Dec 17, 2019

@pieh Whoops, I'll get right on that.

@pieh
Copy link
Contributor

pieh commented Dec 17, 2019

Thanks @jariz!

It's not burning issue (other than not being able to actually publish blog post), so don't go out of your way to do this ;) I can prep skeleton one with empty bio and twitter (not sure if they are required), because I see that

@jariz
Copy link
Contributor Author

jariz commented Dec 17, 2019

No worries, just opened #20172.

@AishaBlake
Copy link

Oh noooo, that's on me. Thanks for taking care of this, y'all!

@pieh
Copy link
Contributor

pieh commented Dec 17, 2019

Oh noooo, that's on me. Thanks for taking care of this, y'all!

I'd say that's on all of us. It might be worth to invest a bit in our automation to make check like that as this is something that robots will be good at (this is not the first blog post we forgot about this).

And yeah, thanks so much for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants